Add rate limit handling to embedders #425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellasia
reviewed
Sep 22, 2025
|
|
||
| def is_rate_limit_error(exception: Exception) -> bool: | ||
| """Check if an exception is a rate limit error from any LLM provider. | ||
| """Check if an exception is a rate limit error from any LLM provider or embedder. |
There was a problem hiding this comment.
Do you think we can move this file somewhere else now that it's not only used for LLMs?
There was a problem hiding this comment.
sure, I thought about that, but it would be a breaking change. unless we believe most people aren’t calling the rate limit handler directly and are just relying on the default one. I’m fine with moving it, but I wanted to point out the potential drawback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the rate limiting functionality (previously available only for LLMs) to all embedding providers, and ensures consistent error handling
Type of Change
Complexity
Low
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):